Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate vs docs: <em> in <description> #278

Closed
marcusmueller opened this issue Jul 4, 2020 · 6 comments
Closed

Validate vs docs: <em> in <description> #278

marcusmueller opened this issue Jul 4, 2020 · 6 comments

Comments

@marcusmueller
Copy link

marcusmueller commented Jul 4, 2020

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-description says that <em> is valid in <description>. appstreamcli validate (0.12.7) begs to differ.

Without a machine-readable scheme, it's not clear who's right.

@ximion
Copy link
Owner

ximion commented Jul 4, 2020

This is not a bug - code and em are only supported since AppStream 0.12.8 (released ~1y ago), so you'll need to upgrade to at least that version (ideally though to 0.12.11, the latest release).

@ximion ximion closed this as completed Jul 4, 2020
@marcusmueller
Copy link
Author

@ximion wouldn't that imply that the "applies to appstream 0.12" headline in the docs is insufficiently specific?

@marcusmueller
Copy link
Author

@ximion by the way, can't find a CHANGELOG that describes that; I've neither been able to find the commit from the commit messages (git log --summary v0.12.10..v0.12.11) that adds that?

@ximion
Copy link
Owner

ximion commented Jul 4, 2020

@ximion wouldn't that imply that the "applies to appstream 0.12" headline in the docs is insufficiently specific?

It applies to the 0.12 series (which doesn't make any breaking changes - that said, breaking changes of the spec are very unlikely at this point anyway). Now that DAPS is used for building the docs, we could probably add the full version somewhere as well.

@ximion by the way, can't find a CHANGELOG that describes that; I've neither been able to find the commit from the commit messages (git log --summary v0.12.10..v0.12.11) that adds that?

https://github.com/ximion/appstream/blob/master/NEWS#L158

@marcusmueller
Copy link
Author

@ximion thanks!!

@ximion
Copy link
Owner

ximion commented Jul 4, 2020

git log --summary v0.12.10..v0.12.11

This was added in 0.12.8, so you could have found it via git log --summary v0.12.7..v0.12.11 - but that's a ton of changes to go through, the NEWS file is much easier (that one contains only the highlights, without stuff like typo fixes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants