as_validate_has_hyperlink gives false positives

[cassidyjames]

as_validate_has_hyperlink causes validation to fail if I even mention the stand-alone string ftp:// in my release notes—without any actual hostname, which I did for my browser since I now handle protocols. :)

appstream/src/as-validator.c

Lines 447 to 464 in dd557bf

	/**
	* as_validate_has_hyperlink:
	*
	* Check if @text contains a hyperlink.
	*/
	static gboolean
	as_validate_has_hyperlink (const gchar *text)
	{
	if (text == NULL)
	return FALSE;
	if (g_strstr_len (text, -1, "http://") != NULL)
	return TRUE;
	if (g_strstr_len (text, -1, "https://") != NULL)
	return TRUE;
	if (g_strstr_len (text, -1, "ftp://") != NULL)
	return TRUE;
	return FALSE;
	}

See: cassidyjames/ephemeral#260 (comment)

[ximion]

Fun! :-) Looks like we may need a regular expression here then (although I also could do some string expression fun, which may be faster). In any case, definitely a false-positive validation error, thanks for reporting it!