Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstream-generator doesn't accept dual-licensed metadata #323

Closed
City-busz opened this issue Jun 8, 2021 · 3 comments
Closed

appstream-generator doesn't accept dual-licensed metadata #323

City-busz opened this issue Jun 8, 2021 · 3 comments
Assignees

Comments

@City-busz
Copy link

Evince specifies GPL-2.0+ or GFDL-1.3-only as metadata license, but it's not accepted by appstream-generator as a permissive license. Since the metadata is dual-licensed and one of them is permissive, it should be accepted by appstream-generator.

Tested with appstream 0.14.3 and appstream-generator 0.8.4.

@ximion
Copy link
Owner

ximion commented Jun 21, 2021

The metadata_license tag does not accept a license expression, and actually even only a list of accepted licenses.
This should likely be made even more clear in the specification (https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license) as well as the explanation of the appstream-generator issue tag.

@ximion ximion self-assigned this Jun 21, 2021
@City-busz
Copy link
Author

So it must be fixed in the evince package by removing GPL-2.0+ from metadata_license? I requested it from the developers, but they said that the metainfo file is reported as valid by appstreamcli validate. You can see their comment here:
https://gitlab.gnome.org/GNOME/evince/-/merge_requests/346#note_1135950

@ximion
Copy link
Owner

ximion commented Jun 21, 2021

Oh, that is indeed not okay - looks like a bug in appstream-generator then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants