Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't check some things appstream-util checks #334

Closed
agx opened this issue Jul 12, 2021 · 1 comment
Closed

Doesn't check some things appstream-util checks #334

agx opened this issue Jul 12, 2021 · 1 comment

Comments

@agx
Copy link

agx commented Jul 12, 2021

I had appstreamcli validate a metainfo file but appstream-util still spotted missing optional tags:

• tag-missing           : <content_rating> required [use https://odrs.gnome.org/oars]
• file-invalid          : <screenshot> failed to load [https://source.puri.sm/guido.gunther/livi/-/blob/main/screenshots/landscape-fullscreen.png]
• tag-missing           : <release> required

Would be great if appstreamcli would check a superset of appstream-util especially since flathub uses appstream-util to validate submissions.

@ximion
Copy link
Owner

ximion commented Jul 12, 2021

Those, except for the file-invalid one, aren't issues though, so they would at max be info priority things. I don't know if we can spam people to use release tags yet, but for the content_rating one we could probably emit a hint for at least GUI applications (not sure about console apps, and it makes no sense for things like firmware).

For the screenshot though: The issue is that the file downloaded isn't actually a PNG image but a HTML page, right? Libappstream can't hard-depend on something like GDK for image loading (due to being lightweight without GUI dependencies and cross-toolkit), but maybe we can work something else out - e.g. test the MIME type of the downloaded image, or test for a PNG magic number explicitly, or at least test for "not HTML text".

@ximion ximion closed this as completed in 3464f53 Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants