Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom node isn't being exported to collection metadata #339

Closed
tintou opened this issue Jul 22, 2021 · 4 comments
Closed

custom node isn't being exported to collection metadata #339

tintou opened this issue Jul 22, 2021 · 4 comments

Comments

@tintou
Copy link
Contributor

tintou commented Jul 22, 2021

Per the collection specification, the custom node isn't visible, would it make sense to add it there (we are using it in elementary AppCenter to enhance our store).

@ximion
Copy link
Owner

ximion commented Jul 23, 2021

What do you mean with "isn't visible"? Does libappstream not read it when it's present (it should), or is the custom entry not present in the source XML? In the latter case, the issue is with your metadata generator, which, in case it's appstream-generator, will need a whitelist of allowed custom keys that it should put into the generated XML or YAML.
See AllowedCustomKeys in https://github.com/ximion/appstream-generator/blob/master/docs/asgen-config.md#toplevel-fields for reference.

@tintou
Copy link
Contributor Author

tintou commented Jul 23, 2021

Unfortunately, for flatpak that's still libappstream-glib, and it produces a metadata entry instead of custom (per https://github.com/hughsie/appstream-glib/blob/e98c97fcd4e0ffa17b00f842c9bad462bf7c3afb/libappstream-glib/as-app.c#L4834 ) but that should be fixed by at least increasing the version in hughsie/appstream-glib#407
This bug is more toward the specification that doesn't seem to cover this field, even in the optional case.

@ximion
Copy link
Owner

ximion commented Jul 23, 2021

What do you expect the specification to say about it? Looks like you kind of already found the source of your issue, with a solution for it.
The custom tag is, by definition, optional.

@ximion
Copy link
Owner

ximion commented Feb 10, 2023

Closing, as bug is stale.

@ximion ximion closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants