Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstream's APT configuration files are using wrong commenting syntax #409

Closed
Jason-Lee-Quinn opened this issue Jun 8, 2022 · 1 comment

Comments

@Jason-Lee-Quinn
Copy link

Jason-Lee-Quinn commented Jun 8, 2022

Hi, the files

/contrib/apt-conf/50appstream
/contrib/apt-conf/60icons
/contrib/apt-conf/60icons-hidpi
/contrib/apt-conf/60icons-large
/contrib/apt-conf/60icons-large-hidpi

are all using a double hash (##) for comments but apt uses C-style comments (as per "man 5 apt.conf").

This causes some tools to fail. For example, the command "cupt why" causes the cupt package manager to complain with warnings like

E: syntax error: line 1, character 1: expected: clear directive ('#clear') or option name (letters, numbers, slashes, points, dashes, double colons allowed)
E: unable to parse the config file '//etc/apt/apt.conf.d/60icons'
W: skipped the configuration file '//etc/apt/apt.conf.d/60icons'

for each file mentioned.

Each apt configuration file should be converted to C-style commenting.

@Jason-Lee-Quinn
Copy link
Author

This is probably a false alarm. The most recent version of APT's man pages suggest that the hash is a valid comment character,

https://github.com/Debian/apt/blob/edffb0ae26935d948ffeb3be229fdcf37d2a1ee1/doc/apt.conf.5.xml

Might still be worth considering switching over to the C-style comments. The hash as a comment character seems to be rarely used and it will take some time for software that utilizes APT to adopt the new convention.

I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant