Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Form-Factors to appstreamcli make-desktop-file #415

Closed
jsparber opened this issue Jun 27, 2022 · 4 comments
Closed

Add Form-Factors to appstreamcli make-desktop-file #415

jsparber opened this issue Jun 27, 2022 · 4 comments

Comments

@jsparber
Copy link

See: https://adrienplazas.com/blog/2020/10/15/specify-form-factors-in-your-librem-5-apps.html

Related: #400 (comment)
@jsparber
Copy link
Author

Actually, I'm not sure how to move forward on this, since we have the appropriate information now in appstream, but AFAIK the .desktop file entire is still needed.

@ximion
Copy link
Owner

ximion commented Aug 2, 2022

Is it needed? Can't the DE simply get the required information from the metainfo file, or is there a reason why we want to duplicate the information in a desktop-entry file?

@jsparber
Copy link
Author

jsparber commented Aug 3, 2022

I filled an issue against Phosh https://gitlab.gnome.org/World/Phosh/phosh/-/issues/817

@jsparber
Copy link
Author

jsparber commented Aug 3, 2022

This can be closed since in future we will use metainfo file https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/950

@jsparber jsparber closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ximion @jsparber