New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The appstream specification is too vague about how to write release notes #458
Comments
|
The release description is really a freeform text, the same you get on GitHub - you can make it look like you want, for example: <release type="stable" version="0.15.5" date="2022-08-22T00:00:00Z">
<description>
<p>This release adds the following features:</p>
<ul>
<li>validator: Allow severity downgrade of releases-not-in-order for GNOME</li>
<li>validator: Perform stricter integer validation</li>
<li>validator: Check for url redefinitions</li>
<li>Add convenience function that check if component is free by license and origin</li>
...
</ul>
<p>This release updates documentation:</p>
<ul>
<li>spec: Add an <internet/> kind to requires/recommends/supports</li>
...
</ul>
<p>This release fixes the following bugs:</p>
<ul>
<li>validator: Don't permit overriding the unknown root tag issue</li>
<li>compose: Don't crash if metainfo file contains an invalid stock icon</li>
<li>spdx: Fix possible crash when NULL is passed to is_free_license</li>
...
</ul>
<p>This release includes the following changes:</p>
<ul>
<li>Silence static analyzer false-positives based on GCC version</li>
...
</ul>
<p>With contributions from:</p>
<p>JakobDev, Philip Withnall, Pino Toscano, Matthias Klumpp</p>
</description>
</release>The issue tag is used wrong in your example, it is not a translatable freeform text. From https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Releases.html#tag-release-issues :
It's best to simply give a short summary as to which bug was fixed in the release description, so users don't need to click on stuff. The Software centers don't need to display issue tags, they're optional (but it's of course pretty nice if they are displayed). |
I think my url element does this, https://github.com/mike-fabian/ibus-typing-booster/releases/tag/2.19.7 gives detailed information about the release but it is not displayed by gnome-software. |
Unfortunately it is not displayed to the user, and if it were, how should the bug number look like to indicate from what tracker the bug number is? |
I used to have it like that, but I wanted to include URLs to the issues fixed and So I moved the URLs to But if I do <description>
...
<li>Some text describing the issue (Resolves: https://github.com/foo/bar/issues/4711)</li>
...
</description>
...
<issue url="https://github.com/foo/bar/issues/4711">4711</issue>
...then the issue url and the short describing text are somehow separated and one could not see quickly which issue this is, even if gnome-software displayed the contents of the |
That is a bug in gnome-software, please file an issue with them!
It will simply become a clickable link in the software center GUI, like LP: #1914868 or appstream: #1914868 Have a look at https://fwupd.org/lvfs/devices/com.fujitsu.LIFEBOOK.E5510-E5410.uefi.firmware for example as to how this may look like with CVE IDs (which is what this feature was originally designed for).
Yes, that's how it is right now - I'd just add the issue number to the text, and if you want to link it, add it as issue tag as well. Or don't link it and only link issues in the detailed report on the webpage you point to. Keep in mind that the |
From my point of view, the specification could benefit from including some examples of acceptable bug ID formats to use in We’re looking at implementing |
Patches welcome ;-) |
Try and make it a bit clearer what formats are expected, and when URLs are expected to be given. What was there before was not incorrect, but was a bit hard to unpack. Add a couple more examples inline. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: ximion#458
Given that it’s typically written right after the `<description>` element, there’s a temptation to think that it will be presented right after the prose in the description. But that’s not necessarily the case. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: ximion#458
Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: ximion#458
Try and make it a bit clearer what formats are expected, and when URLs are expected to be given. What was there before was not incorrect, but was a bit hard to unpack. Add a couple more examples inline. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #458
Given that it’s typically written right after the `<description>` element, there’s a temptation to think that it will be presented right after the prose in the description. But that’s not necessarily the case. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #458
Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #458
|
Thank you! |
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Releases.html#tag-release-issues
The specification is quite vague about what can be written in the
<description>and<issue>tags for a release.Long ago I wrote long bulleted lists with links to the issues fixed into
<description>but thenappstreamcli --validatecomplained, it did not want me to use URLs in the description and I was not able to achieve a nice looking formatted result of the text either. If I remember correctly, list usingul/lidid not work in<description>.Therefore, I changed
<description>to only contain a generic message likeBugs fixedand tried to put the detailed informationinto the
<issue>tags, for example like:But gnome-software does not display that at all, see:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2049#note_1648786
The gnome-software developer Milan Crha and me both think that the specification does not say clearly what exactly to write into the
<issue>tags. What I did above seems reasonable to me, but when reading the specification I am not sure whether it is OK like that.Can you please clarify this?
The text was updated successfully, but these errors were encountered: