Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10 doesn't provide screenshot url info #66

Closed
antonio-rojas opened this issue Aug 31, 2016 · 12 comments
Closed

0.10 doesn't provide screenshot url info #66

antonio-rojas opened this issue Aug 31, 2016 · 12 comments
Assignees
Labels

Comments

@antonio-rojas
Copy link
Contributor

With 0.10, 'appstream-cli get --details' doesn't provide a screenshot url anymore. The data has been extracted with "createScreenshotsStore": false and screenshot urls are available in the app-info xmls.

@ximion ximion added the bug label Aug 31, 2016
@ximion ximion self-assigned this Aug 31, 2016
@ximion ximion closed this as completed in cef772a Aug 31, 2016
@antonio-rojas
Copy link
Contributor Author

still not getting screenshot urls with cef772a, is any other commit required?

@ximion
Copy link
Owner

ximion commented Aug 31, 2016

@antonio-rojas Did you run appstreamcli refresh --force? Are you using XML or YAML metadata as source data?

@antonio-rojas
Copy link
Contributor Author

Yes, I ran appstreamcli refresh-cache --force. The metadata is in XML.

@ximion
Copy link
Owner

ximion commented Aug 31, 2016

Hmm, are you sure you have the right appstreamcli and the right libappstream?
Because I just tried this here with the Arch metadata and got the expected screenshots...

@antonio-rojas
Copy link
Contributor Author

yes, I just tried git head and still doesn't work

@ximion
Copy link
Owner

ximion commented Aug 31, 2016

Weird...
Can you paste the output of appstreamcli status? Also run appstreamcli dump <component-id> with a component-ID for a component that has screenshots, and check if the screenshot tags are present in the output.

@antonio-rojas
Copy link
Contributor Author

antonio-rojas commented Aug 31, 2016

`> appstreamcli status
AppStream Status:
Version: 0.10.1

Distribution metadata:
/usr/share/app-info

  • XML: 3

  • Iconsets:
    archlinux-arch-core
    archlinux-arch-extra
    archlinux-arch-community

    /var/lib/app-info

  • Empty.

    /var/cache/app-info

  • Empty.

Metainfo files:

  • Found 97 components.
  • Found 81 components in legacy paths.

Summary:
We have information on 985 software components.`

appstreamcli dump org.kde.dolphin.desktop doesn't output any screenshot tag.

@ximion
Copy link
Owner

ximion commented Aug 31, 2016

Hmm, strange, I can not reproduce this at all...
Also, these codepaths are all unit-tested now, so this really should work. Does make test complete without failure?

@antonio-rojas
Copy link
Contributor Author

Yep, all tests pass. No idea what could be the problem, I even tried regenerating the xmls but it makes no difference.

@ximion
Copy link
Owner

ximion commented Aug 31, 2016

The tests read, write and cache read/write metadata, which is exactly what ascli does as well...
So, I have no idea what could be broken here...
Maybe remove all AppStream libraries you have installed and install the master copy again, to be 100% sure nothing is interfering...

If nothing helps, I will fetch some arch user (maybe @aleixpol ) at Akademy and try to reproduce the issue there.
With the Archlinux metadata on Debian, at least, this problem doesn't happen.

@antonio-rojas
Copy link
Contributor Author

ok found it... it was the old cached data from /var/cache/app-info that was somehow interfering. After wiping that dir and regenerating the cache once again it works. Thanks for the help.

@ximion
Copy link
Owner

ximion commented Sep 1, 2016

Oh, that should not happen - if you run with --force, the old data should be overridden...
But good that it's working now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants