Sorting is not prefering name matches

[aleixpol]

For example, looking for writer doesn't prioritize libreoffice writer.over calligra author.

$ appstreamcli search writer
Identifier: gco.desktop [desktop]
Name: GNOME Comics Organizer
Summary: A GNOME interface for managing your comic book collection
Package: gco
Icon: gco_gco-gco.png
----
Identifier: author.desktop [desktop]
Name: Calligra Author
Summary: Write ebooks and textbooks
Package: calligraauthor
Icon: calligraauthor_calligraauthor.png
----
Identifier: org.gnome.MultiWriter.desktop [desktop]
Name: MultiWriter
Summary: Write an ISO file to multiple USB devices at once
Package: gnome-multi-writer
Homepage: https://wiki.gnome.org/Apps/MultiWriter
Icon: gnome-multi-writer_gnome-multi-writer.png
----
Identifier: libreoffice-writer.desktop [desktop]
Name: LibreOffice Writer
Summary: Create and edit text and graphics in letters, reports, documents and Web pages by using Writer.
Package: libreoffice-writer
Homepage: http://www.libreoffice.org/discover/writer/
Icon: libreoffice-writer_libreoffice-writer.png
----

[larryprice]

It looks to me like it is preferring names but in reverse, which I assumed was by design.

In fact, the sorting line that is used specifically sorts the search results by score, as seen here: https://github.com/ximion/appstream/blob/master/src/as-pool.c#L1051

Furthermore, there is a comment in the as_pool_search function which states the results will be unordered, though it definitely uses the as_sort_components_by_score_cb sorting function to order the results by score.

So it's really just a question of what is the preferred way to return search results? I also would have expected them to be sorted from highest score match to lowest.

[ximion]

Indeed, I made a mistake there :-)
Thanks for looking into this and providing a patch!