appstreamqt doesn't list urls

[aleixpol]

I made a little test application that reproduces the issue. I can reproduce on KDE Neon, can't reproduce on ArchLinux.

https://github.com/aleixpol/appstreamqttest

[aleixpol]

$ ./appstreamqttest libreoffice-calc.desktop
name: LibreOffice Calc
urls:
$ appstreamcli get --details libreoffice-calc.desktop
Identifier: libreoffice-calc.desktop [desktop]
Name: LibreOffice Calc
Summary: Perform calculations, analyze information and manage lists in spreadsheets by using Calc.
Package: libreoffice-calc
Homepage: http://www.libreoffice.org/discover/calc/
Icon: libreoffice-calc_libreoffice-calc.png
Description: Calc is a powerful and extensible spreadsheet program, part of the LibreOffice 
  productivity suite. Newcomers find it intuitive and easy to learn. Professional 
  data miners and number crunchers will appreciate the comprehensive range of 
  advanced functions.

  LibreOffice supports opening and saving into a wide variety of formats, so you 
  can easily share spreadsheets with users of other popular office suites without 
  worrying about compatibility.
Sample Screenshot URL: http://appstream.ubuntu.com/media/main/l/li/libreoffice-calc.desktop/f1875c714ce4f3152749f1a99a0021c3/screenshots/source/scr-1.png
License: MPL-2.0
Categories: Office, Spreadsheet, X-Red-Hat-Base, X-MandrivaLinux-Office-Spreadsheets
Provided Items: ↓
 Mimetypes: text/tab-separated-values application/clarisworks application/excel 
  application/vnd.oasis.opendocument.chart application/x-iwork-numbers-sffnumbers 
  application/x-ms-excel application/vnd.oasis.opendocument.spreadsheet-template text/x-csv 
  application/x-excel application/tab-separated-values 
  application/vnd.sun.xml.calc.template text/comma-separated-values application/x-123 application/vnd.sun.xml.calc 
  application/vnd.ms-excel.sheet.macroenabled.12 text/csv 
  application/vnd.openxmlformats-officedocument.spreadsheetml.template 
  application/vnd.oasis.opendocument.spreadsheet application/vnd.lotus-1-2-3 application/x-quattropro application/x-dbf 
  application/x-dbase application/x-msexcel application/msexcel 
  application/vnd.openxmlformats-officedocument.spreadsheetml.sheet application/vnd.ms-works 
  application/vnd.oasis.opendocument.chart-template application/vnd.ms-excel 
  application/vnd.ms-excel.sheet.binary.macroenabled.12 
  application/vnd.oasis.opendocument.spreadsheet-flat-xml application/x-dos_ms_excel 
  application/vnd.ms-excel.template.macroenabled.12 application/csv text/x-comma-separated-values text/spreadsheet 

[ximion]

This is probably an issue with the metadata...
I even added a few more unittests for Url stuff, but I couldn't reproduce this issue:

make && ./appstreamqttest org.kde.gwenview.desktop
[100%] Built target appstreamqttest
name: Gwenview
urls:
1 UrlKindHomepage: http://gwenview.kde.org/
2 UrlKindBugtracker: https://bugs.kde.org/enter_bug.cgi?format=guided&product=gwenview
4 UrlKindHelp: http://docs.kde.org/stable/en/kdegraphics/gwenview/index.html

Maybe on Neon the metadata is generated without metainfo file, and therefore no URLs are present?

[aleixpol]

That's odd... 😞
How do you explain though that on neon it's found by appstreamcli but not by the test?

@apachelogger can you maybe shed some light?

[ximion]

It makes no sense... But this line looks kind of suspicious to me: https://github.com/ximion/appstream/blob/master/qt/database.cpp#L161

Everything appstreamcli can find must be accessible via the Qt bindings as well, because they use almost the same code.
One thing that also looks weird to me though is that you don't seem to be using the latest version of AppStream (0.10.1 - judging by the output formatting of ascli, this one is rather old, probably 0.9.8). Can you run appstreamcli status on Neon and see if you are up to date?

[aleixpol]

now that's certainly odd:

$ appstreamcli status
AppStream Status:
Version: 0.9.8
...

[ximion]

Can you update that and see if the issue persists? If you have a mix of different libappstream and libappstream-qt versions on your system, that could very well cause this issue. The libraries aren't really meant to be mixed in different versions.

[hsitter]

Riddell forked the packaging from debian. you'll have to talk to him about inconsistencies

[aleixpol]

It was a packaging issue.

[ximion]

At least we got even more test coverage from it :D