Make Qt5 default #1
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussing with Ximion it, it looks like nobody is using Appstream-Qt4, so it's fair to just use by default the most common one. At some point it will make sense to make it Qt5 only, to take advantage of Qt5 features. This is just a first step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
After discussing with Ximion it, it looks like nobody is using
Appstream-Qt4, so it's fair to just use by default the most common
one.
At some point it will make sense to make it Qt5 only, to take
advantage of Qt5 features. This is just a first step.