Provide an error message as warning output #101
Conversation
| @@ -66,7 +66,13 @@ Pool::~Pool() | |||
|
|
|||
| bool Pool::load() | |||
| { | |||
| return as_pool_load (d->m_pool, NULL, NULL); | |||
| GError* error = nullptr; | |||
There was a problem hiding this comment.
Ideally use g_autoptr here:
g_autoptr(GError) error = nullptr;
(then you can get rid of the g_error_free line)
|
I always dislike libraries printing stuff to stdout/stderr, so while I would be okay with this change, I think it's just a workaround. Can we propagate the error in a useful way somehow? (by returning an error struct, using C++ errors, or adding a lastError QString property (or struct, if we want to preserve the error code) to the class or doing something else.) |
|
I see your point, but it's not like the application can do anything other than showing the error message in a fancy pointless way. |
|
The application using the library might want to show the information in an unobtrusive popup, add more information to it and display it, write it to its own logfile and send it to the developers with other diagnostic info and possibly other things I don't know of. (I think we can still merge this, but I would like a consistent way to report errors in AppStreamQt much more) |
As discussed in the issue ximion#97, there's some systems where appstream is reporting that it doesn't load properly but the users on the platform don't have information on how to fix it. Provide a warning for frontends to display, giving indications on what's the problem.
As discussed in the issue #97, there's some systems where appstream is
reporting that it doesn't load properly but the users on the platform
don't have information on how to fix it.
With this warning, they will at least have a chance to know.