Jump to conversation
Unresolved conversations (6)
@aleixpol aleixpol Jun 16, 2017
include possibly not needed?
qt/launchable.cpp
grulja
@aleixpol aleixpol Jun 16, 2017
A vector should be enough?
qt/contentrating.cpp
ximion grulja
@aleixpol aleixpol Jun 16, 2017
Why not a hash here?
Outdated
qt/contentrating.cpp
grulja
@ximion ximion Jun 16, 2017
The CI complains about a missing return statement here... And I was also surprised that this thing is public API, but looking at `AsComponent` it indeed is...
Outdated
qt/component.cpp
grulja ximion
@ximion ximion Jun 14, 2017
Adding launchable to the Qt interface is actually a must-be-present feature for the next release, as that's a key new feature and using `desktopId` is deprecated in favor of it.
Outdated
qt/component.h
grulja ximion
@ximion ximion Jun 14, 2017
Are these really necessary? I would argue that this is only needed in case the Qt/C++ interface is incomplete and someone therefore wants to use the C library directly. In that case, we should rather fix the Qt binding to include the missing stuff, and not give library users the means to hack around it and not report the issue.
qt/bundle.h
ximion grulja
Resolved conversations (0)