Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AS::Metadata class used for parsing desktop and appstream metadatadata files #118

Closed
wants to merge 4 commits into from

Conversation

grulja
Copy link
Contributor

@grulja grulja commented Jun 15, 2017

Please note that this won't compile, because it depends on my previous review needing AS::Component::asComponent() for addComponent() method.

@ximion ximion requested a review from aleixpol June 20, 2017 09:26
Copy link
Collaborator

@aleixpol aleixpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all it looks good to me. +1

qt/metadata.cpp Outdated

AppStream::Metadata::FormatVersion AppStream::Metadata::stringToFormatVersion(const QString& formatVersionString)
{
if (formatVersionString == QLatin1String("0.11")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use versionMap.key()?

qt/metadata.h Outdated
static QString formatVersionToString(FormatVersion version);

Metadata();
Metadata(_AsMetadata *metadata);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit?

@ximion
Copy link
Owner

ximion commented Jun 21, 2017

Okay :-)
Can you please resolve the conflicts of this branch (remove the merge) so that a proper rebase merge is possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants