Fix infinite loop bug. #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the parameter, old is an empty string for some reason, conditions of both for loops will be never finished. To fix the bug, added one more condition that if oldlen is 0, loops never run. from: (q = strstr(p, old)) != NULL to : (oldlen != 0) && (q = strstr(p, old)) != NULL Edited: src/as-utils.c
|
@memnoth Did you ever hit this issue when using AppStream? Or did you find it when reading the code? |
|
The bug had been up in this issue: elementary/appcenter#588 Thank you! |
|
@memnoth Oooh, very interesting! The cases you never thing would happen ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the parameter, old is an empty string for some reason, conditions of both for loops will be never finished. To fix the bug, added one more condition that if oldlen is 0, loops never run.