Check also plain language string in as_component_localized_get #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the component doesn't contain translated data for the given locale string, try the plain language string before falling back to C Fixes ximion#166
|
This can be made a bit more efficient, but I'll change that in master. |
ximion
added a commit
that referenced
this pull request
Apr 3, 2018
Only split language from locale if we really need to, and free allocated string from the split properly. This resolves an issue inroduced with the last commit. CC PR #185
|
This patch also contained a memory leak, but that's all resolved in master. Thanks again for debugging the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the component doesn't contain translated data for the given locale string, try the plain language string before falling back to C
Fixes #166