lower cmake requirement to 3.1.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaf7229 suggests that it was bumped to 3.2 for CMAKE_CXX_STANDARD, this feature was however introduced in 3.1. lower the cmake requirement from 3.2 to 3.1 to align with the actual requirements
|
Makes sense to me, it's better if we can run it on more systems. |
aleixpol
added a commit
that referenced
this pull request
Jan 11, 2016
Lower cmake requirement to 3.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
eaf7229 suggests that it was bumped to
3.2 for CMAKE_CXX_STANDARD, this feature was however introduced in 3.1.
lower the cmake requirement from 3.2 to 3.1 to align with the actual
requirements
tested on 3.1.1