Fix a couple of incorrect g_ptr_array_unrefs #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In as_pool_save_cache_file() and test_pool_read() we were calling g_ptr_array_unref() without NULLing the autopointer. This results in two unrefs for one ref which is bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In as_pool_save_cache_file() and test_pool_read() we were calling
g_ptr_array_unref() without NULLing the autopointer. This results in
two unrefs for one ref which is bad.
This is breaking the testsuite with GLib 2.57.2 which now catches this and throws a critical.