Set error variable if there were some errors during refinement#201
Merged
ximion merged 1 commit intoximion:masterfrom Aug 28, 2018
Merged
Set error variable if there were some errors during refinement#201ximion merged 1 commit intoximion:masterfrom
ximion merged 1 commit intoximion:masterfrom
Conversation
When as_pool_refine_data encounters bad components, this is reflected in the return code, but there is no further information given what went wrong. Give a short hint to the user, and refer to the debug output which allows determining the cause.
Owner
|
This makes sense. Thank you for the patch! |
Owner
|
Looks like I was a bit too quick with merging this: |
Contributor
Author
|
oops - g_error_new_literal ... |
ximion
added a commit
that referenced
this pull request
Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When as_pool_refine_data encounters bad components, this is reflected
in the return code, but there is no further information given what went
wrong. Give a short hint to the user, and refer to the debug output which
allows determining the cause.