Skip to content

Comments

Set error variable if there were some errors during refinement#201

Merged
ximion merged 1 commit intoximion:masterfrom
StefanBruens:master
Aug 28, 2018
Merged

Set error variable if there were some errors during refinement#201
ximion merged 1 commit intoximion:masterfrom
StefanBruens:master

Conversation

@StefanBruens
Copy link
Contributor

When as_pool_refine_data encounters bad components, this is reflected
in the return code, but there is no further information given what went
wrong. Give a short hint to the user, and refer to the debug output which
allows determining the cause.

When as_pool_refine_data encounters bad components, this is reflected
in the return code, but there is no further information given what went
wrong. Give a short hint to the user, and refer to the debug output which
allows determining the cause.
@ximion
Copy link
Owner

ximion commented Aug 28, 2018

This makes sense. Thank you for the patch!

@ximion ximion merged commit 558c7c8 into ximion:master Aug 28, 2018
@ximion
Copy link
Owner

ximion commented Aug 28, 2018

Looks like I was a bit too quick with merging this:

../src/as-pool.c:1020:12: error: implicit declaration of function 'g_new_error_literal'; did you mean 'g_set_error_literal'? [-Werror=implicit-function-declaration]
   *error = g_new_error_literal(AS_POOL_ERROR,

@StefanBruens
Copy link
Contributor Author

oops - g_error_new_literal ...

ximion added a commit that referenced this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants