component: Mark relevant return types as nullable #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are not marked as nullable in the resulting GIR file and hence not marked nullable in any bindings downstream of that; for example, the Vala bindings. Having these marked as nullable would allow more robust Vala code to be generated when these methods are used. This only touches Component for now in case there's some reasoning behind why these haven't been marked `nullable`, but I'm happy to submit a PR to cover off the rest if this is wanted.
|
Makes sense, I think when the code was written I didn't know that return values can be tagged as nullable as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These types are not marked as nullable in the resulting GIR file and hence not marked nullable in any bindings downstream of that; for example, the Vala bindings.
Having these marked as nullable would allow more robust Vala code to be generated when these methods are used.
This only touches Component for now in case there's some reasoning behind why these haven't been marked
nullable, but I'm happy to submit a PR to cover off the rest if this is wanted.