Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null checks in as_release_vercmp #206

Closed
wants to merge 1 commit into from
Closed

Add null checks in as_release_vercmp #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 src/as-release.c
View file
Open in desktop
@@ -268,8 +268,20 @@ as_release_set_version (AsRelease *release, const gchar *version)
gint
as_release_vercmp (AsRelease *rel1, AsRelease *rel2)
{
return as_utils_compare_versions (as_release_get_version (rel1),
as_release_get_version (rel2));
const gchar* ver1 = as_release_get_version (rel1);
const gchar* ver2 = as_release_get_version (rel2);

if (ver1 == NULL || ver2 == NULL) {
if (ver1 != NULL) {
return 1;
} else if (ver2 != NULL) {
return -1;
} else {
return 0;
}
}

return as_utils_compare_versions (ver1, ver2);
}

/**