qt: expose the spdx parser to Qt users #213

aleixpol · 2019-01-09T14:35:27Z

No description provided.

ximion · 2019-01-09T16:04:04Z

qt/spdx.cpp

+    return QString::fromUtf8(as_spdx_license_detokenize(tokens));
+}
+
+QString AppStream::SPDX::asLicenseId(const QString &license)


This should likely be called toSpdxId or licenseToId, since the purpose of this function is to create a SPDX-compatible identifier from a more "generic" license name.

ximion · 2019-01-10T15:31:44Z

Thank you for the patch!

ximion reviewed Jan 9, 2019

View changes

qt: expose the spdx parser to Qt users

7c0ddcf

aleixpol force-pushed the qtspdx branch from c0ad822 to 7c0ddcf Compare January 9, 2019 19:30

ximion merged commit 87a1019 into ximion:master Jan 10, 2019

qt: expose the spdx parser to Qt users #213

qt: expose the spdx parser to Qt users #213

aleixpol commented Jan 9, 2019

ximion Jan 9, 2019

ximion commented Jan 10, 2019

qt: expose the spdx parser to Qt users #213

qt: expose the spdx parser to Qt users #213

Conversation

aleixpol commented Jan 9, 2019

ximion Jan 9, 2019

Choose a reason for hiding this comment

ximion commented Jan 10, 2019