Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests breaking in GLib 2.59 (GHashTable order changed) #223

Merged
merged 2 commits into from Mar 24, 2019

Conversation

robert-ancell
Copy link
Contributor

No description provided.

This stops the tests breaking when the GHashTable ordering changed in GLib 2.59.
@robert-ancell
Copy link
Contributor Author

From #222

@robert-ancell
Copy link
Contributor Author

This doesn't fix all the code that uses the ordering, but seems to be enough to fix the tests.

@ximion
Copy link
Owner

ximion commented Mar 24, 2019

Looks good to me, thank you for doing all the work!
I also like that the sorting overhead ended up almost exclusively in the serialization functions (I don't think this will work forever though ^^).
The changes should be fairly complete, given that one of the tests involves loading a large XML file, serializing it to the GVariant cache, loading it and then comparing the result.
But any further issues will be uncovered by future testsuite expansions :-)

@ximion ximion merged commit 0609f04 into ximion:master Mar 24, 2019
ximion added a commit that referenced this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants