its: Add translatable option in metainfo.its #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but why would you ever not want to translate an agreement section name? |
fujiwarat
force-pushed
the
its-no-trans-name
branch
from
84693ac
to
bd3a5ff
Compare
Some packages do not wish to extract the component name as translatable since it's the branding name and add the translatable option. ximion#229
fujiwarat
force-pushed
the
its-no-trans-name
branch
from
bd3a5ff
to
6a018d3
Compare
|
Sorry, you're right. I deleted the agreement section name line. |
|
Makes sense to me now! Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some package does not wish to extract the component name
as translatable since it's the branding name and add the
translatable option.
#229