Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort addons less prominently than applications #257

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@aleixpol
Copy link
Collaborator

aleixpol commented Oct 7, 2019

Otherwise we get a bunch of addons whenever we search for the
application in question.

See https://bugs.kde.org/show_bug.cgi?id=407588

After:

Identifier: org.kde.kdevelop.desktop [desktop-application]
Name: KDevelop
Summary: Featureful, plugin-extensible IDE for C/C++ and other programming languages
Package: kdevelop
Homepage: https://kdevelop.org
Icon: kdevelop_kdevelop.png
---
Identifier: org.kde.kdev-python [addon]
Name: KDevelop Python Support
Summary: Python language support for KDevelop
Package: kdevelop-python
Homepage: https://kdevelop.org
Icon: kdevelop-python_kdevelop.png
---
Identifier: org.kde.kdev-php [addon]
Name: KDevelop PHP Support
Summary: PHP language support for KDevelop
Package: kdevelop-php
Homepage: https://kdevelop.org
Icon: kdevelop-php_kdevelop.png

Before:

Identifier: org.kde.kdev-python [addon]
Name: KDevelop Python Support
Summary: Python language support for KDevelop
Package: kdevelop-python
Homepage: https://kdevelop.org
Icon: kdevelop-python_kdevelop.png
---
Identifier: org.kde.kdevelop.desktop [desktop-application]
Name: KDevelop
Summary: Featureful, plugin-extensible IDE for C/C++ and other programming languages
Package: kdevelop
Homepage: https://kdevelop.org
Icon: kdevelop_kdevelop.png
---
Identifier: org.kde.kdev-php [addon]
Name: KDevelop PHP Support
Summary: PHP language support for KDevelop
Package: kdevelop-php
Homepage: https://kdevelop.org
Icon: kdevelop-php_kdevelop.png
Otherwise we get a bunch of addons whenever we search for the
application in question.

See https://bugs.kde.org/show_bug.cgi?id=407588
@ximion

This comment has been minimized.

Copy link
Owner

ximion commented Oct 15, 2019

I think doing this is fair game. I was originally looking into something more advanced, involving absorbing more metadata from an addon into the parent component, and then devaluing the addon explicitly, given that most software centers display addons alongside their matching components.
but this will do as well for now. The patch needs some style fixed (a token-type is an uint that mustn't go below zero), but I'll just fix that afterwards.

@ximion ximion merged commit 4cc28fe into ximion:master Oct 15, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ximion

This comment has been minimized.

Copy link
Owner

ximion commented Oct 15, 2019

It is really odd that Cuttlefish still has a higher score than KDevelop if you search for "kdevelop" - even if the latter has an exact match for the term in its description multiple times, and also matches exactly with its name.
I'll have to look into that, maybe some stemming weirdness is going on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.