Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same locale fallback for releases as for components #262

Closed
wants to merge 1 commit into from
Closed

Use the same locale fallback for releases as for components #262

wants to merge 1 commit into from

Conversation

tintou
Copy link
Contributor

@tintou tintou commented Dec 11, 2019

This fixes the issue with release metadata not showing the translation in elementary AppCenter

@tintou
Copy link
Contributor Author

tintou commented Dec 11, 2019

My locale is fr_FR.UTF-8 but we only provide translations for fr not fr_FR

@ximion
Copy link
Owner

ximion commented Dec 22, 2019

Hey, just a quick feedback: Your patch fixes this issue only for one particular locale, but I think this has to be addressed in a much more generic way in a different place (AsContext maybe) and with less code duplication.
I am keeping this PR open at time as a reminder to work on this, and I'll merge it when I start working on the generic solution.
Originally I wanted to do one more AppStream release before the end of the year, but it appears like we'll instead get one with this issue fixed at the beginning of January next year.
Thanks for your contribution and sorry for not replying sooner!

@ximion
Copy link
Owner

ximion commented Jan 11, 2020

I've implemented this differently now, but also in a more complete way, so the same algorithm is now used for every translation that AppStream has.
Thank you for the initial PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants