Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make as_component_get_sort_score public #271

Closed
wants to merge 1 commit into from

Conversation

davidmhewitt
Copy link
Contributor

Fixes #269

It turns out that this is a guint rather than a custom type, so this works out perfectly in the vapi.

I know you wanted to have a bit more of a think about this in terms of whether this score is suitable for comparing components in disparate pools and whether this is the right approach, but I feel happier that I've done a tiny bit of the leg work 😝

@davidmhewitt
Copy link
Contributor Author

@ximion Sorry to chase you, but have you had any chance to think about this? Is there anything else I can do to help out with this?

@ximion
Copy link
Owner

ximion commented May 9, 2020

It's a custom type because it's typedef'ed, but the sort score return value happens to be a guint.
I will make this public API, but I'll go with a different patch than this one because I will also have to adjust some documentation texts (and I would rather do this in one commit). So, the next release will likely have this.
Thank you for creating this PR though!

@ximion ximion closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose component sort_score as public API?
2 participants