Use glib-mkenums to create the GType of all the available enums #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this amount of hard-coding really necessary? Is there a bug report against gobject-introspection, so, will this issue be fixed upstream in any reasonable amount of time? |
tintou
changed the title
|
@ximion I indeed found the root cause of this issue: none of these enums were registered to the GObject Type system, I've added the use of glib-mkenum to generate their GType. |
This allows the GObject Introspection to correctly understand the relations between all the from_string/to_string methods and the enum they belong to. This also allows to use the right GType when dealing with flags or enums.
|
Looks like this got lost in ancient times during the cmake transition (!). Great find, and the patch looks good to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This allows the GObject Introspection to correctly understand the relations between all the from_string/to_string methods and the enum they belong to.
This also allows to use the right GType when dealing with flags or enums.