New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not propagate a null GError #298

Merged

ximion merged 1 commit into ximion:master from aleixpol:no-propagate-nullptr

Jan 12, 2021

+2 −1

Collaborator

aleixpol commented Jan 12, 2021

I used to get:

** (process:12057): DEBUG: 05:26:52.319: No component found in desktop-entry file: SparkleShare.Autostart.desktop

(process:12057): GLib-CRITICAL **: 05:26:52.319: g_propagate_error: assertion 'src != NULL' failed

Possibly because the desktop file is broken, but it's good not to throw critical errors like that.


          Do not propagate a null GError

c54ddf2

Owner

ximion commented Jan 12, 2021

Looks like this could use a test! - Apparently the testsuite only tests good desktop-entry files, not broken ones.
Thanks for the PR!

ximion merged commit 1292a78 into ximion:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment