Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as-content-rating: Fix a typo in the type macro for AsContentRating #318

Merged
merged 1 commit into from May 30, 2021

Conversation

pwithnall
Copy link
Contributor

This is technically an API break, but since it was a violation of the
GObject naming conventions, it seems likely that nobody had encountered
it before (or relied on it), otherwise it would have been reported.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

This is technically an API break, but since it was a violation of the
GObject naming conventions, it seems likely that nobody had encountered
it before (or relied on it), otherwise it would have been reported.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
@pwithnall
Copy link
Contributor Author

pwithnall commented May 27, 2021

This is an API break. If you’d prefer to fix this without breaking API, I could put together an alternative patch which maintains a backwards-compatibility #define.

This PR does not break ABI, as it’s only changing a macro, not an exported symbol.

@ximion ximion merged commit aaac0fe into ximion:master May 30, 2021
6 checks passed
@ximion
Copy link
Owner

ximion commented May 30, 2021

Brr, such an annoying error! Looks like a string-replace mistake.
Since this doesn't break ABI and a quick search in open source code found no users of the old macro and it is easy to fix and will yield a backwards-compatible binary, I am fine with merging the patch.
The only annoying thing is that making code that builds with older and new libas versions will need a version check for this if it uses the macro...

Thanks for finding this and providing a patch!

@pwithnall pwithnall deleted the content-rating-type branch June 1, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants