Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component: Don't strip ";" from keywords before translating them #320

Merged
merged 1 commit into from Jun 3, 2021

Commits on Jun 3, 2021

  1. component: Don't strip ";" from keywords before translating them

    We're failing to translate strings now, when the keywords ends with a
    ";" as they almost always do, e.g.:
    
      Keywords=Drivers;Repositories;Repository;PPA;
    
    because we strip the trailing semicolon off before translating, in order
    to avoid having empty elements in the output.
    
    Instead what we can do is process the list passed to
    `as_component_set_keywords` and remove empties at that point. This
    allows us to not modify the string retrieved from the desktop file, and
    fixes finding translations.
    Iain Lane committed Jun 3, 2021