Jump to conversation
Unresolved conversations (1)
@iainlane iainlane Jun 21, 2021
that's a typo (c+p from glib)
src/as-utils.c
Resolved conversations (6)
@iainlane iainlane Jun 21, 2021
seems like an API & ABI break; maybe we can't implement this suggestion?
src/as-utils.h
@ximion ximion Jun 13, 2021
`g_autofree gchar *locale_noenc = NULL;`, otherwise we'll crash if `strv == NULL`.
Outdated
src/as-yaml.c
@ximion ximion Jun 13, 2021
Can you throw the whole code of this function behind a GLib version check macro, so we fall back to the GLib-internal version as soon as it is available with newer GLib? That also makes the code self-explanatory and is easy to grep for once we do raise the minimum GLib version. See `as_date_time_format_iso8601` for one such example: https://github.com/ximion/appstream/blob/master/src/as-utils.c#L1744-L1782 (there's quite a few more in AppStream's code)
src/as-utils.c
@robert-ancell robert-ancell Jun 7, 2021
Brace should be on the end of the previous line to match existing style.
Outdated
src/as-utils.c
ximion iainlane
@robert-ancell robert-ancell Jun 7, 2021
`@search` > `@find`
Outdated
src/as-utils.c
@robert-ancell robert-ancell Jun 7, 2021
Nit: added an extra newline here.
Outdated
src/as-utils.c