New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Make Pool's parent class public #332

Merged

ximion merged 1 commit into master from work/make-parent-public

Jul 5, 2021

Collaborator

aleixpol commented Jul 5, 2021

It's not the default but what we generally do. It allows us to call
parent class methods normally.


          qt: Make Pool's parent class public

994b1e1

It's not the default but what we generally do. It allows us to call
parent class methods normally.

ximion merged commit c2c7826 into master

9 of 10 checks passed

Owner

ximion commented Jul 5, 2021

I think the base class not being public was a mistake here, actually. Thanks for the patch!

ximion deleted the work/make-parent-public branch

October 8, 2021 05:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment