spec: Mention the already-supported scale attribute of <icon/>#353
Merged
ximion merged 1 commit intoximion:masterfrom Sep 9, 2021
Merged
spec: Mention the already-supported scale attribute of <icon/>#353ximion merged 1 commit intoximion:masterfrom
ximion merged 1 commit intoximion:masterfrom
Conversation
Owner
|
Wow, looks like this was indeed forgotten from the spec! The rule is that the spec change is committed first, and the implementation follows that, apparently on the scale property, that process either didn't exist yet or was ignored. |
ximion
requested changes
Sep 8, 2021
As I understand it, these changes just document the existing semantics and don’t change anything. Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
pwithnall
force-pushed
the
icon-scale
branch
from
dd7c725 to
22acbf2
Compare
Owner
|
Looks good, thank you! I do notice though that the icons are still explained for "collection metadata", while nowadays we should describe stuff for metainfo files first and only have the collection document describe differences (so this is currently backwards). That's an artifact from when the metainfo spec didn't exist, as collection data was first, and should probably be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand it, these changes just document the existing semantics
and don’t change anything.
Signed-off-by: Philip Withnall pwithnall@endlessos.org