Skip to content

Comments

spec: Mention the already-supported scale attribute of <icon/>#353

Merged
ximion merged 1 commit intoximion:masterfrom
pwithnall:icon-scale
Sep 9, 2021
Merged

spec: Mention the already-supported scale attribute of <icon/>#353
ximion merged 1 commit intoximion:masterfrom
pwithnall:icon-scale

Conversation

@pwithnall
Copy link
Contributor

As I understand it, these changes just document the existing semantics
and don’t change anything.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

@ximion
Copy link
Owner

ximion commented Sep 8, 2021

Wow, looks like this was indeed forgotten from the spec! The rule is that the spec change is committed first, and the implementation follows that, apparently on the scale property, that process either didn't exist yet or was ignored.
Thanks for noticing and creating the PR!

As I understand it, these changes just document the existing semantics
and don’t change anything.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
@ximion
Copy link
Owner

ximion commented Sep 9, 2021

Looks good, thank you!

I do notice though that the icons are still explained for "collection metadata", while nowadays we should describe stuff for metainfo files first and only have the collection document describe differences (so this is currently backwards). That's an artifact from when the metainfo spec didn't exist, as collection data was first, and should probably be changed.
But that's out of scope for this PR :-)

@ximion ximion merged commit ea17e1a into ximion:master Sep 9, 2021
@pwithnall pwithnall deleted the icon-scale branch September 20, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants