metadata: Document file not found error code #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on the port of Flatpak to libappstream[1] I noticed that we currently don't have proper error checking when loading an appstream file with appstream-glib that turns out not to exist.[2] appstream-glib was patched to return G_IO_ERROR_NOT_FOUND in that case[3] and libappstream already does so in its corresponding API, but this patch documents that so that if the implementation here is changed it will hopefully still meet this requirement. [1] flatpak/flatpak#4426 [2] https://github.com/flatpak/flatpak/blob/284edffe89ecb78a19d01da065030d9f3bf31c76/app/flatpak-builtins-utils.c#L1169 [3] hughsie/appstream-glib#268
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Nov 10, 2021
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Nov 10, 2021
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Nov 10, 2021
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
|
Looks good, thank you for the patch! :-) |
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Nov 10, 2021
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Nov 15, 2021
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
mwleeds
added a commit
to pwithnall/flatpak
that referenced
this pull request
Jan 27, 2022
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
mwleeds
added a commit
to flatpak/flatpak
that referenced
this pull request
Feb 17, 2022
Now that we switched from appstream-glib we don't need this hack. See ximion/appstream#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While working on the port of Flatpak to libappstream[1] I noticed that
we currently don't have proper error checking when loading an appstream
file with appstream-glib that turns out not to exist.[2] appstream-glib
was patched to return G_IO_ERROR_NOT_FOUND in that case[3] and
libappstream already does so in its corresponding API, but this patch
documents that so that if the implementation here is changed it will
hopefully still meet this requirement.
[1] flatpak/flatpak#4426
[2] https://github.com/flatpak/flatpak/blob/284edffe89ecb78a19d01da065030d9f3bf31c76/app/flatpak-builtins-utils.c#L1169
[3] hughsie/appstream-glib#268