Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: Document file not found error code #362

Merged
merged 1 commit into from Nov 10, 2021
Merged

metadata: Document file not found error code #362

merged 1 commit into from Nov 10, 2021

Commits on Nov 10, 2021

  1. metadata: Document file not found error code 

    While working on the port of Flatpak to libappstream[1] I noticed that
we currently don't have proper error checking when loading an appstream
file with appstream-glib that turns out not to exist.[2] appstream-glib
was patched to return G_IO_ERROR_NOT_FOUND in that case[3] and
libappstream already does so in its corresponding API, but this patch
documents that so that if the implementation here is changed it will
hopefully still meet this requirement.

[1] flatpak/flatpak#4426
[2] https://github.com/flatpak/flatpak/blob/284edffe89ecb78a19d01da065030d9f3bf31c76/app/flatpak-builtins-utils.c#L1169
[3] hughsie/appstream-glib#268
    @mwleeds
    mwleeds committed Nov 10, 2021
    8ff9c4f