docs: document media_baseurl property of components #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property is inserted[1] into XML collection metadata by appstream-generator, but is undocumented. [1]https://github.com/ximion/appstream-generator/blob/master/src/asgen/engine.d#L318
|
Jup, this was an experimental feature for a while, that kind of became the norm for collection data. |
gnomesysadmins
pushed a commit
to GNOME/gnome-software
that referenced
this pull request
Jan 18, 2022
This property was not documented for XML data until quite recently: ximion/appstream#371 However, remote icons and screenshots generated with appstream-generator only contain urls relative to media_baseurl property. Fix all relative uris prepending the corresponding media_baseurl for those objects to be downloadable.
gnomesysadmins
pushed a commit
to GNOME/gnome-software
that referenced
this pull request
Mar 14, 2022
This property was not documented for XML data until quite recently: ximion/appstream#371 However, remote icons and screenshots generated with appstream-generator only contain urls relative to media_baseurl property. Fix all relative uris prepending the corresponding media_baseurl for those objects to be downloadable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property is inserted[1] into XML collection metadata by
appstream-generator, but is undocumented.
[1]https://github.com/ximion/appstream-generator/blob/master/src/asgen/engine.d#L318