Check missing release props #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
requested changes
Jan 6, 2022
This tag can be used if a release tag is missing the version which should be present according to section 2.1: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-releases
This tag can be used if a release tag is missing both date and timestamp which should be present according to section 2.1: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-releases
fortysixandtwo
force-pushed
the
check-missing-release-props
branch
from
dad99ce
to
e96b1fd
Compare
|
v2: Split into |
|
This looks good now, thank you for the patch! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
appstream-utilchecks for missing timestamp property, so we can do the same.What prompted me to check this, was having had a typo
data=...instead ofdate=...which was caught byappstream-util, but not byappstreamcli.An alternative solution could iterate the properties of the release tag and check for unknowns (if that is preferred).
I'm also not sure if the info severity is a good choice or if it should be bumped to warning