Fix translate URL #380
Merged
Fix translate URL #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, something went massively wrong here... Good catch! |
|
Should I rename UrlTranslate to UrlKindTranslate? It never worked and there are no Issues about it, so I don't think it is used in any code. |
ximion
added a commit
that referenced
this pull request
Jan 26, 2022
ximion
added a commit
that referenced
this pull request
Jan 26, 2022
The Qt way is of course nicer, but it's yet another place to keep a string table up to date, so calling the C library for that conversion is a lot more convenient in the long run and easier to maintain. And unless people are doing insane things with the ASQt API, the additional overhead should not be noticeable. CC: #380
No, we can't do that as that would still be an API break (the enum value was valid afterall and some client could have used it in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While looking at the source, I saw that UrlTranslate is defined in Header as part of UrlKind but not set.
btw:
Is there any reason why it is named UrlTranslate and not UrlKindTranslate like the other?