Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcs-browser and contribute URL type #392

Merged
merged 3 commits into from Mar 29, 2022
Merged

Conversation

JakobDev
Copy link
Contributor

This PR adds vcs-browser and contribute as URL types as in #374. It was easier and cleaner to make a new PR than to update the old one.

Copy link
Owner

@ximion ximion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the VCS enum name that should go after its string representation, for clarity.

src/as-enums.h Outdated Show resolved Hide resolved
@JakobDev
Copy link
Contributor Author

I had now replaced AS_URL_KIND_VCS with AS_URL_KIND_VCS_BROWSER

ximion
ximion approved these changes Mar 29, 2022
@ximion ximion merged commit dec3821 into ximion:master Mar 29, 2022
9 checks passed
@ximion
Copy link
Owner

ximion commented Mar 29, 2022

Looks good now, thank you for the patch! :-)

@ximion ximion mentioned this pull request Mar 29, 2022
@JakobDev
Copy link
Contributor Author

JakobDev commented Mar 29, 2022

I informed GNOME and KDE that the new types has been added. Would be nice, if you can create a new release. It will take some time until the distros ship the new Version, so the Implementation in the Software Centers can be started.

Edit:
I also ping @aleixpol and @cassidyjames which were involved in the original discussion.

@JakobDev JakobDev deleted the vcscontribute branch March 29, 2022 21:11
@cassidyjames
Copy link

Thanks @JakobDev, I'll file the appropriate issues on elementary software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants