New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vcs-browser and contribute URL type #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for the VCS enum name that should go after its string representation, for clarity.
|
I had now replaced AS_URL_KIND_VCS with AS_URL_KIND_VCS_BROWSER |
|
Looks good now, thank you for the patch! :-) |
|
I informed GNOME and KDE that the new types has been added. Would be nice, if you can create a new release. It will take some time until the distros ship the new Version, so the Implementation in the Software Centers can be started. Edit: |
|
Thanks @JakobDev, I'll file the appropriate issues on elementary software. |
This PR adds vcs-browser and contribute as URL types as in #374. It was easier and cleaner to make a new PR than to update the old one.