Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate timestamp #403

Merged
merged 4 commits into from May 22, 2022
Merged

Validate timestamp #403

merged 4 commits into from May 22, 2022

Conversation

JakobDev
Copy link
Contributor

Fixes #402. This fix is a simple if, which doesn't needed much experience in C, so I decried to do the fix myself. I checked for a Timestamp smaller than 3000, if someone has the idea to use the Year as timestamp. I guess no one wants to use 1970/1/1 as release date in the Appstream, so it wouldn't break anything.

src/as-validator.c Outdated Show resolved Hide resolved
Copy link
Owner

@ximion ximion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, and then this should be good to go!

src/as-validator-issue-tag.h Outdated Show resolved Hide resolved
src/as-validator.c Outdated Show resolved Hide resolved
src/as-validator.c Outdated Show resolved Hide resolved
src/as-validator.c Outdated Show resolved Hide resolved
@ximion
Copy link
Owner

ximion commented May 22, 2022

Thanks for the patch!

ximion
ximion approved these changes May 22, 2022
@ximion ximion merged commit dedd45f into ximion:master May 22, 2022
9 checks passed
@JakobDev JakobDev deleted the timestampvalidate branch May 22, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appstreamcli doesn't validate timestamp
2 participants