Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix as_display_length_kind_from_px() #404

Merged
merged 2 commits into from May 30, 2022
Merged

Fix as_display_length_kind_from_px() #404

merged 2 commits into from May 30, 2022
+8 −8

Conversation

JakobDev
Copy link
Contributor

The current implementation returns AS_DISPLAY_LENGTH_KIND_SMALL when px is higher than 360 and AS_DISPLAY_LENGTH_KIND_XSMALL when px is 360 or lower. All other are not returned. This bug was found by LGTM.

@ximion
Copy link
Owner

ximion commented May 30, 2022

Neat, thanks!
Please keep in mind that we will likely remove the labelled text values in AppStream 1.0, so they should not be used if possible.

@ximion ximion merged commit c3dbb4b into ximion:master May 30, 2022
8 of 9 checks passed
@JakobDev
Copy link
Contributor Author

Why did you plan to remove this?

@JakobDev JakobDev deleted the displayfix branch May 30, 2022 14:50
@ximion
Copy link
Owner

ximion commented May 30, 2022

Because of #335
This has been an annoyance from the very start, and others convinced me that trying to define human-readable size classes is a futile exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakobDev @ximion