Check if URL type is redefined #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should definitely be done using a bitfield, or at the very least by using GHashTable as a set, rather than a map. But the bitfield method would be a lot nicer (and crazy efficient compared to the rather wasteful hash table). |
|
Could you provide a example for bitfield? |
|
Check out https://en.wikipedia.org/wiki/Bit_field, but the linked commit that implements this is probably a lot better as a reference. AppStream has a few macros which make bitwise operations easier as well :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This checks, if a URL type is used more than once. The code is based on c6e5d65. It is tested and it works. Hope I got everything right.