New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update duplicate checking #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good overall, I had just a bunch of style comments and the tag_id that's added to the hash table should be the unlocalized one in case a tag isn't translatable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you for the patch! :-)
This PR adds 2 things:
as_validator_check_appear_once() currently allow all tags to have translations. This doesn't make sense for tags like project_license. You can't have one License for English users and one for Spanish users. I added a argument to tell, if translations are allowed or not. If not, the new Issuetag unsupported-translation will be raised.
I added the duplicate check to a few more tags e.g. .
Please tell me, if a made a mistake at some point.