Merged
Conversation
ximion
requested changes
Jun 13, 2022
Owner
ximion
left a comment
ximion
left a comment
There was a problem hiding this comment.
This looks pretty good overall, I had just a bunch of style comments and the tag_id that's added to the hash table should be the unlocalized one in case a tag isn't translatable.
ximion
requested changes
Jun 14, 2022
ximion
approved these changes
Jun 14, 2022
Owner
ximion
left a comment
ximion
left a comment
There was a problem hiding this comment.
Looks good now, thank you for the patch! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 things:
as_validator_check_appear_once() currently allow all tags to have translations. This doesn't make sense for tags like project_license. You can't have one License for English users and one for Spanish users. I added a argument to tell, if translations are allowed or not. If not, the new Issuetag unsupported-translation will be raised.
I added the duplicate check to a few more tags e.g. .
Please tell me, if a made a mistake at some point.