Skip to content

Comments

Update duplicate checking#408

Merged
ximion merged 5 commits intoximion:masterfrom
JakobDev:betterduplicates
Jun 14, 2022
Merged

Update duplicate checking#408
ximion merged 5 commits intoximion:masterfrom
JakobDev:betterduplicates

Conversation

@JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Jun 3, 2022

This PR adds 2 things:

  1. as_validator_check_appear_once() currently allow all tags to have translations. This doesn't make sense for tags like project_license. You can't have one License for English users and one for Spanish users. I added a argument to tell, if translations are allowed or not. If not, the new Issuetag unsupported-translation will be raised.

  2. I added the duplicate check to a few more tags e.g. .

Please tell me, if a made a mistake at some point.

Copy link
Owner

@ximion ximion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good overall, I had just a bunch of style comments and the tag_id that's added to the hash table should be the unlocalized one in case a tag isn't translatable.

Copy link
Owner

@ximion ximion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you for the patch! :-)

@ximion ximion merged commit c43051f into ximion:master Jun 14, 2022
@JakobDev JakobDev deleted the betterduplicates branch June 15, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants