Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (8)
@ximion ximion Jun 14, 2022
style: Put closing bracket and else in one line please (always `} else {`)
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
If we are on a tag that can not be translated, we really shouldn't set `tag_id` to the localized identifier, but emit a warning and do `tag_id = g_strdup (node_name);`, so: ```c if (translatable) { tag_id = g_strdup_printf ("%s (lang=%s)", node_name, lang); } else { tag_id = g_strdup (node_name); as_validator_add_issue (validator, node, "unsupported-translation", node_name); } ``` Otherwise we'll not emit some important warnings at first go in case a file has multiple errors.
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
style: This *does* need braces now, as the following `else` branch also has them
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
nit: extra space not needed
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
style: Single-statement if clause shouldn't have extra braces.
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
style: Please use snake_case => `allow_translations` - but for conciseness, I'd probably name this `translatable` or `allow_l10n` (your choice though) :)
Outdated
src/as-validator.c
@ximion ximion Jun 13, 2022
typo: better: `This tag is not translatable` (everything is per the specification, so we usually omit overly verbose wording)
Outdated
src/as-validator-issue-tag.h
@ximion ximion Jun 13, 2022
naming: better: `translation-unsupported` or `tag-not-translatable`
Outdated
src/as-validator-issue-tag.h