data: use lxml to get the XDG categories #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use lxml to get the list of XDG categories from the DocBook file using XPath queries; this simplifies the code a bit, and makes it more robust. There is no change in the extracted data.
|
I think the original intent was to only use Python stdlib stuff... But XPath queries are so much nicer, thank you for improving this piece of code! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use lxml to get the list of XDG categories from the DocBook file using
XPath queries; this simplifies the code a bit, and makes it more robust.
There is no change in the extracted data.