Add an <internet/> kind to requires/recommends/supports (2) #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows apps to specify whether they require the internet to work, or whether they explicitly work fully without internet. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Signed-off-by: Matthias Klumpp <matthias@tenstral.net> Fixes: #343
ximion
force-pushed
the
wip/mak/rel_internet
branch
from
e01cc04
to
f84f0de
Compare
|
It is missing a validation, but otherwise it looks OK |
|
Indeed! I'll add validation for it before this is released. |
|
Yay, thanks everyone :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a fixed up version of #421 that is ready to merge (due to @pwithnall being on vacation and there's no reason to leave this 99.9% completed feature out of the next release).
@cassidyjames @JakobDev Please have a look if you see any issues, otherwise I hope I can merge this in time for the release that will likely happen in the evening next Monday.