Add an <internet/> kind to requires/recommends/supports /3 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows apps to specify whether they require the internet to work, or whether they explicitly work fully without internet. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Signed-off-by: Matthias Klumpp <matthias@tenstral.net> Fixes: #343
|
Maybe you should also add a example for offline-only, so they User know in which relations-tag he should put it. |
|
This is shaping up to be the most extensive example block in the whole specification :-D - I normally like to keep the examples quite brief, as information should be derivable from the text, but I also do see the point here of adding an example for it in a |
|
I found this in the documentation as exmaple: <!-- never uses the internet, even if available -->
<requires>
<internet>never</internet>
</requires>This is invalid and should be offline-only. |
|
Ha! Well spotted! Thanks for having another look, it's good to not make a release with these obvious but very confusing errors (and I didn't spot that when reviewing the original PR!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a version of #425 with some minor fixes and added validation.